Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix boolean parameter type in c++ plugins #49

Merged
merged 1 commit into from
Sep 7, 2018
Merged

fix boolean parameter type in c++ plugins #49

merged 1 commit into from
Sep 7, 2018

Conversation

rrrapha
Copy link
Contributor

@rrrapha rrrapha commented Sep 6, 2018

Resolves #48

ddennedy
ddennedy approved these changes Sep 6, 2018
View reviewed changes
Copy link
Collaborator

@ddennedy ddennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed output of melt -query filter=frei0r.premultiply for me by converting its parameter from "type: float" to "type: boolean". Also, tested that the boolean parameter toggles as expected.

jaromil
jaromil approved these changes Sep 7, 2018
View reviewed changes
Copy link
Member

@jaromil jaromil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixes go in the right direction, that of abandoning the use of f0r_param wrapping of variables of native types.

@jaromil
Copy link
Member

jaromil commented Sep 7, 2018

Hi Raphael, thanks for this and other recent contributions and welcome to the frei0r club :^)

@ddennedy ddennedy merged commit dd07f13 into dyne:master Sep 7, 2018
@rrrapha rrrapha deleted the bool-param branch September 8, 2018 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaromil jaromil jaromil approved these changes

@ddennedy ddennedy ddennedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rrrapha @jaromil @ddennedy