[WIP] towards OpenCV4 support #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imgproc_c.h defines the constants CV_BGR2GRAY, CV_FILLED & CV_AA. it also includes "core/core_c.h", which then provides `cvGetTickCount()` and `cvGetTickFrequency()`
|
relates to #93 |
|
The deprecated constructors have also been removed from OpenCV 3.4.9. |
rrrapha
reviewed
Mar 5, 2020
| @@ -21,6 +21,9 @@ | |||
| #include <stdio.h> | |||
| #include <string.h> | |||
| #include <opencv2/opencv.hpp> | |||
| #if CV_MAJOR_VERSION >= 4 | |||
| # include <opencv2/imgproc/imgproc_c.h> | |||
| #endif | |||
|
This PR can be dropped... |
|
is there already OpenCV4 support? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the starting point for OpenCV-4 support.
some problems are trivial to fix by including the relevant new header files).
however, afaict the high-level object detection code has seen a major overhaul, and needs a complete rewrite.
this PR at least fixes the simple problems (allowing to compile
facedetect, but not yetfacebl0r.