-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autotools fixes #95
autotools fixes #95
Conversation
much easier to override
AM_CFLAGS is really a fallback, if there are no explicit per-target CFLAGS set
CFLAGS is really only for C-files CPPFLAGS is for the C-PreProcessor
it's redundant, as C(XX)FLAGS are always added to each target
Thanks! Its still true that the cmake setup is the best maintained and AFAIK most used. |
I vote to remove the autotools build. |
even though i personally despise CMake and very much prefer autotools, i completely agree (as hinted in the original post) that it's better to remove autotools than to have it lingering around unmaintained. |
as of frei0r-1.8, |
ah, i just noticed that there's ee21d09 right after it would be fantastic if the build-systems were tested before doing a release (probably using a CI; my casual glance seems to indicate that the travis-ci no longer runs autotools builds). or: simple remove the buildsystem that is unmaintained. |
the autotools setup is in a sorry state, and seems to be not very well tested.
it wrongly uses
CFLAGS
(andCPPFLAGS
) for C++-projects (ndvi
,facebl0r
,facedetect
), resulting inafaict, there's also a misunderstanding of how
AM_*FLAGS
are supposed to work:they are really used to define fallback-flags, if no per-target flags are specified. however, if you do specify per-target flags (as is the case for a couple of filters), the
AM_*FLAGS
will be ignored unless manually added.it seems thatautotools
is a 2nd-class citizen (as opposed tocmake
), and is not tested with CI.it's probably OK to only support a single build-system, but then we should just drop the unsupported build-systems completely...
EDIT: sorry, I missed that
autotools
are indeed tested in.travis.yml
; too well hidden behind docker :-)