autotools fixes

[umlaeute]

the autotools setup is in a sorry state, and seems to be not very well tested.

it wrongly uses CFLAGS (and CPPFLAGS) for C++-projects (ndvi, facebl0r, facedetect), resulting in

• unability to build out-of-tree
• not passing of crucial build-flags

afaict, there's also a misunderstanding of how AM_*FLAGS are supposed to work:
they are really used to define fallback-flags, if no per-target flags are specified. however, if you do specify per-target flags (as is the case for a couple of filters), the AM_*FLAGS will be ignored unless manually added.

it seems that autotools is a 2nd-class citizen (as opposed to cmake), and is not tested with CI.
it's probably OK to only support a single build-system, but then we should just drop the unsupported build-systems completely...

EDIT: sorry, I missed that autotools are indeed tested in .travis.yml; too well hidden behind docker :-)

[jaromil]

Thanks! Its still true that the cmake setup is the best maintained and AFAIK most used.
Feedback is welcome on your proposition, perhaps to be debated also on the mailinglist?
I agree that maintaining one build system is probably enough.

[ddennedy]

I vote to remove the autotools build.

[umlaeute]

even though i personally despise CMake and very much prefer autotools, i completely agree (as hinted in the original post) that it's better to remove autotools than to have it lingering around unmaintained.

[umlaeute]

as of frei0r-1.8, autotools is still (or: again?) broken, as it references a non-existing file TODO.

[umlaeute]

ah, i just noticed that there's ee21d09 right after v1.8.0, which fixes this.

it would be fantastic if the build-systems were tested before doing a release (probably using a CI; my casual glance seems to indicate that the travis-ci no longer runs autotools builds).

or: simple remove the buildsystem that is unmaintained.

[jaromil]

Hi @umlaeute !! thanks for your maintenance and patience, I'm following up on your advice and consolidating the cmake based build, will setup a ci for test builds using both make, ninja and nmake for msvc target, see #130