Fix for implicit publish on add/remove node #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if self._implicitPublish is True: | ||
| publish = "Y" | ||
| else: | ||
| publish = "N" |
There was a problem hiding this comment.
You could simplify to publish = "Y" if self._implicitPublish else "N"
|
Huh, yeah, this function is a bit different eh? No _update() implicit publish trickery since it calls the session directly. Only publish(), delete(), and "Get" type calls should "ignore" implicitPublish. I did a quick skim through and found one other call (Line 4168) that needs this publish check. Not surprisingly it part of the Node Functionality. Other than that, this change LGTM. +1 |
|
Merging PR with 2 reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Marchowes @moogar0880 Can you guys check this, it's a quick change to the add_node/remove_node functions on TD. Currently it is hardcoded to publish immediately which is causing problems.