Remove BPatch_dll.h (#1739)

Since 67bc82c, this no longer serves a purpose. The definition for V_libdyninstAPI was removed by dee8900 in 2011.
dyninst · May 5, 2024 · 170c01d · 170c01d
1 parent 67bc82c
commit 170c01d
Show file tree

Hide file tree

Showing 26 changed files with 9 additions and 97 deletions.
diff --git a/dyninstAPI/CMakeLists.txt b/dyninstAPI/CMakeLists.txt
@@ -14,7 +14,6 @@ set(_public_headers
     h/BPatch_basicBlockLoop.h
     h/BPatch_binaryEdit.h
     h/BPatch_callbacks.h
-    h/BPatch_dll.h
     h/BPatch_edge.h
     h/BPatch_enums.h
     h/BPatch_flowGraph.h
@@ -298,7 +297,6 @@ dyninst_library(
   dyninstAPI
   PUBLIC_HEADER_FILES ${_public_headers}
   SOURCE_FILES ${_sources}
-  DEFINES BPATCH_DLL_BUILD
   DYNINST_DEPS common instructionAPI stackwalk pcontrol patchAPI parseAPI symtabAPI 
   PUBLIC_DEPS Dyninst::Boost_headers
   PRIVATE_DEPS Dyninst::ElfUtils Threads::Threads

diff --git a/dyninstAPI/h/BPatch.h b/dyninstAPI/h/BPatch.h
@@ -32,7 +32,6 @@
 #define _BPatch_h_
 
 #include <stdio.h>
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 #include "BPatch_Set.h"
 #include "BPatch_thread.h"

diff --git a/dyninstAPI/h/BPatch_Set.h b/dyninstAPI/h/BPatch_Set.h
@@ -38,12 +38,13 @@
 #include <assert.h>
 #include <stdlib.h>
 #include <set>
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 #include <iostream>
 #include <algorithm>
 #include <iterator>
 #include <functional>
+#include "dyninst_visibility.h"
+
 #if !defined(DO_INLINE_P)
 #define DO_INLINE_P
 #endif

diff --git a/dyninstAPI/h/BPatch_addressSpace.h b/dyninstAPI/h/BPatch_addressSpace.h
@@ -32,7 +32,6 @@
 #define _BPatch_addressSpace_h_
 
 #include "boost/shared_ptr.hpp"
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 #include "BPatch_enums.h"
 #include "BPatch_instruction.h" // for register type

diff --git a/dyninstAPI/h/BPatch_basicBlock.h b/dyninstAPI/h/BPatch_basicBlock.h
@@ -35,7 +35,6 @@
 #include <set>
 #include <utility>
 #include <vector>
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 #include "BPatch_Set.h"
 #include "BPatch_sourceBlock.h" 

diff --git a/dyninstAPI/h/BPatch_basicBlockLoop.h b/dyninstAPI/h/BPatch_basicBlockLoop.h
@@ -36,7 +36,6 @@
 #include <set>
 #include <vector>
 #include "Annotatable.h"
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 #include "BPatch_Set.h"
 #include "BPatch_basicBlock.h"

diff --git a/dyninstAPI/h/BPatch_binaryEdit.h b/dyninstAPI/h/BPatch_binaryEdit.h
@@ -33,7 +33,6 @@
 
 
 //#include "BPatch_snippet.h"
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 #include "BPatch_image.h"
 #include "BPatch_addressSpace.h"

diff --git a/dyninstAPI/h/BPatch_dll.h b/dyninstAPI/h/BPatch_dll.h
diff --git a/dyninstAPI/h/BPatch_edge.h b/dyninstAPI/h/BPatch_edge.h
@@ -31,8 +31,6 @@
 #ifndef _BPatch_edge_h_
 #define _BPatch_edge_h_
 
-#include "BPatch_dll.h"
-
 class BPatch_flowGraph;
 class BPatch_basicBlock;
 class BPatch_point;

diff --git a/dyninstAPI/h/BPatch_flowGraph.h b/dyninstAPI/h/BPatch_flowGraph.h
@@ -35,14 +35,14 @@
 #include <set>
 #include <map>
 #include "Annotatable.h"
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 #include "BPatch_Set.h"
 #include "BPatch_basicBlock.h"
 #include "BPatch_basicBlockLoop.h"
 #include "BPatch_loopTreeNode.h"
 #include "BPatch_edge.h"
 #include "dyntypes.h"
+#include "dyninst_visibility.h"
 
 class func_instance;
 class AddressSpace;

diff --git a/dyninstAPI/h/BPatch_function.h b/dyninstAPI/h/BPatch_function.h
@@ -36,7 +36,6 @@
 #include <string>
 #include <vector>
 #include "Annotatable.h"
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 #include "BPatch_Set.h"
 #include "BPatch_enums.h"
@@ -45,6 +44,7 @@
 #include "BPatch_memoryAccess_NP.h"
 #include "StackMod.h"
 #include "dyntypes.h"
+#include "dyninst_visibility.h"
 
 class func_instance;
 

diff --git a/dyninstAPI/h/BPatch_image.h b/dyninstAPI/h/BPatch_image.h
@@ -31,7 +31,6 @@
 #ifndef _BPatch_image_h_
 #define _BPatch_image_h_
 
-#include "BPatch_dll.h"
 #include "BPatch_sourceObj.h"
 #include "BPatch_Vector.h"
 #include "BPatch_module.h"

diff --git a/dyninstAPI/h/BPatch_instruction.h b/dyninstAPI/h/BPatch_instruction.h
@@ -31,8 +31,8 @@
 #ifndef _BPatch_instruction_h_
 #define _BPatch_instruction_h_
 
-#include "BPatch_dll.h"
 #include "dyntypes.h"
+#include "dyninst_visibility.h"
 #include <string>
 
 class BPatch_basicBlock;

diff --git a/dyninstAPI/h/BPatch_loopTreeNode.h b/dyninstAPI/h/BPatch_loopTreeNode.h
@@ -33,7 +33,6 @@
 
 #include <map>
 #include <string>
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 #include "BPatch_function.h"
 

diff --git a/dyninstAPI/h/BPatch_module.h b/dyninstAPI/h/BPatch_module.h
@@ -30,11 +30,11 @@
 
 #ifndef _BPatch_module_h_
 #define _BPatch_module_h_
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 #include "BPatch_sourceObj.h"
 #include "BPatch_enums.h"
 #include "dyntypes.h"
+#include "dyninst_visibility.h"
 #include <stddef.h>
 #include <vector>
 #include <map>

diff --git a/dyninstAPI/h/BPatch_object.h b/dyninstAPI/h/BPatch_object.h
@@ -36,7 +36,6 @@
 #include <set>
 #include <utility>
 #include "dyntypes.h"
-#include "BPatch_dll.h"
 #include "StackMod.h"
 
 class mapped_object;

diff --git a/dyninstAPI/h/BPatch_parRegion.h b/dyninstAPI/h/BPatch_parRegion.h
@@ -32,7 +32,6 @@
 #define _BPatch_parRegion_h_
 
 #include <vector>
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 
 class int_parRegion;

diff --git a/dyninstAPI/h/BPatch_point.h b/dyninstAPI/h/BPatch_point.h
@@ -33,7 +33,6 @@
 
 #include <string>
 #include <vector>
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 #include "BPatch_Set.h"
 #include "BPatch_enums.h"

diff --git a/dyninstAPI/h/BPatch_process.h b/dyninstAPI/h/BPatch_process.h
@@ -32,7 +32,6 @@
 #define _BPatch_process_h_
 
 #include "BPatch_snippet.h"
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 // #include "BPatch_image.h"
 #include "BPatch_addressSpace.h"

diff --git a/dyninstAPI/h/BPatch_snippet.h b/dyninstAPI/h/BPatch_snippet.h
@@ -32,7 +32,7 @@
 #define _BPatch_snippet_h_
 
 #include <string>
-#include "BPatch_dll.h"
+#include "dyninst_visibility.h"
 #include "BPatch_Vector.h"
 #include "BPatch_sourceObj.h"
 #include "BPatch_type.h"

diff --git a/dyninstAPI/h/BPatch_sourceBlock.h b/dyninstAPI/h/BPatch_sourceBlock.h
@@ -31,8 +31,8 @@
 #ifndef _BPatch_sourceBlock_h_
 #define _BPatch_sourceBlock_h_
 
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
+#include "dyninst_visibility.h"
 #include <set>
 
 /** this class represents the basic blocks in the source

diff --git a/dyninstAPI/h/BPatch_sourceObj.h b/dyninstAPI/h/BPatch_sourceObj.h
@@ -31,8 +31,8 @@
 #ifndef _BPatch_sourceObj_h_
 #define _BPatch_sourceObj_h_
 
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
+#include "dyninst_visibility.h"
 
 class BPatch_type;
 class BPatch_variableExpr;

diff --git a/dyninstAPI/h/BPatch_statement.h b/dyninstAPI/h/BPatch_statement.h
@@ -31,7 +31,6 @@
 #ifndef _BPATCH_STATEMENT_H_
 #define _BPATCH_STATEMENT_H_
 
-#include "BPatch_dll.h"
 #include "Statement.h"
 class BPatch_module;
 

diff --git a/dyninstAPI/h/BPatch_thread.h b/dyninstAPI/h/BPatch_thread.h
@@ -33,7 +33,6 @@
 
 #include <stdio.h>
 
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 #include "BPatch_image.h"
 #include "BPatch_snippet.h"

diff --git a/dyninstAPI/h/BPatch_type.h b/dyninstAPI/h/BPatch_type.h
@@ -31,7 +31,6 @@
 #ifndef _BPatch_type_h_
 #define _BPatch_type_h_
 
-#include "BPatch_dll.h"
 #include "BPatch_Vector.h"
 #include <string.h>	
 #include <assert.h>

diff --git a/dyninstAPI/h/StackMod.h b/dyninstAPI/h/StackMod.h
@@ -32,7 +32,6 @@
 #define _StackMod_h_
 
 #include <string>
-#include "BPatch_dll.h"
 #include "stackanalysis.h"
 
 class BPatch_function;