Move is_call and is_cft to where they are used

dyninst · Dec 21, 2023 · 2d81c7c · 2d81c7c
1 parent 4bcee51
commit 2d81c7c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/instructionAPI/src/x86/decoder.C b/instructionAPI/src/x86/decoder.C
@@ -222,8 +222,6 @@ namespace Dyninst { namespace InstructionAPI {
 
   void x86_decoder::decode_mem(Instruction const* insn, cs_x86_op const& operand) {
     Expression::Ptr effectiveAddr;
-    auto const isCFT = is_cft(insn->getCategory());
-    auto const isCall = is_call(insn->getCategory());
 
     // TODO: handle segment registers
     if(operand.mem.base != X86_REG_INVALID) {
@@ -250,7 +248,9 @@ namespace Dyninst { namespace InstructionAPI {
       memAST = effectiveAddr;
     else
       memAST = makeDereferenceExpression(effectiveAddr, type);
-    if(isCFT) {
+
+    if(is_cft(insn->getCategory())) {
+      auto const isCall = is_call(insn->getCategory());
       insn->addSuccessor(memAST, isCall, true, false, false);
     } else {
       // Capstone may report register operands as neither read nor written.