Fix astOperatorNode semantics #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9fa5f6d.
Variables are used before checked.
kupsch
approved these changes
Nov 6, 2023
dyninstAPI/src/ast.C
Outdated
| @@ -1584,6 +1592,7 @@ bool AstOperatorNode::generateCode_phase2(codeGen &gen, bool noCost, | |||
| break; | |||
| } | |||
| case operandType::RegOffset: { | |||
| assert(loperand); | |||
There was a problem hiding this comment.
Remove as redundant. Can loperand be NULL here? Line 1303 requires it to be not NULL.
There was a problem hiding this comment.
No, it can't. I just missed it.
dyninstAPI/src/ast.h
Outdated
| @@ -566,6 +572,7 @@ class AstOperatorNode : public AstNode { | |||
|
|
|||
| bool generateOptimizedAssignment(codeGen &gen, int size, bool noCost); | |||
|
|
|||
| AstOperatorNode() {} | |||
There was a problem hiding this comment.
It's never used, so I removed it.
It's checked on line 1303.
I fixed them, but that whole definition can be removed. Its declaration was removed in 2006. I think everything guarded by ASTDEBUG can be removed, given how long that's been broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of consistent checking of empty pointers was fixed by #1609, but those changes broke the semantics of the class. This reverts those changes and fixes the pointer checks more directly.