Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix astOperatorNode semantics #1621

Merged
merged 8 commits into from
Nov 6, 2023
Merged

Fix astOperatorNode semantics #1621

merged 8 commits into from
Nov 6, 2023

Commits on Nov 5, 2023

  1. Revert "Guarantee operands in AstOperatorNode are non-null (#1609)" 

    This reverts commit 9fa5f6d.
    @hainest
    hainest committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    4a00347 View commit details
    Browse the repository at this point in the history

  2. Fix loperand

    @hainest
    hainest committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    4900dab View commit details
    Browse the repository at this point in the history

  3. Use tighter checks on roperand in generateCode_phase2

    @hainest
    hainest committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    56bd456 View commit details
    Browse the repository at this point in the history

  4. Remove useless checks in generateCode_phase2 

    Variables are used before checked.
    @hainest
    hainest committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    7b41c66 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Remove AstOperatorNode default ctor

    @hainest
    hainest committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    58e1b8a View commit details
    Browse the repository at this point in the history

  2. Remove ~AstOperatorNode

    @hainest
    hainest committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    f133f43 View commit details
    Browse the repository at this point in the history

  3. Remove assert on loperand 

    It's checked on line 1303.
    @hainest
    hainest committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    26569de View commit details
    Browse the repository at this point in the history

  4. Add more loperand checks

    @hainest
    hainest committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    abf38c7 View commit details
    Browse the repository at this point in the history