Write to stderr in ParseAPI::parsing_printf #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a per-thread file here is cumbersome. Including the thread id in the message and synchronizing vprintf makes this work for multiple threads.
hainest
added
code cleanup
This is a contentious warning that was added to clang-15. See (https://discourse.llvm.org/t/rfc-c-buffer-hardening/65734/85) for details. Disable it for now. This should be converted to a standard diagnostic suppression in common/compiler_diagnostics.h.
That was an inadvertent change.
kupsch
reviewed
Dec 26, 2023
kupsch
reviewed
Dec 26, 2023
kupsch
reviewed
Dec 26, 2023
parseAPI/src/debug_parse.C
Outdated
| #pragma omp critical | ||
| { | ||
| v = fprintf(stderr, "[thread %d] ", id); | ||
| v &= vfprintf(stderr, format, va); |
There was a problem hiding this comment.
The &= doesn't make sense. fprintf returns the number of characters written or -1 on error. You should record each return value separately in r1 and r2 with a return value of r1 != -1 && r2 != -1) ? (r1 + r2) : -1. Slightly better would be to also only execute the second vprintf if r1 != -1. It is also likely that nothing looks at the return value.
kupsch
requested changes
Dec 26, 2023
kupsch
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a per-thread file here is cumbersome. Including the thread id in the message and synchronizing vprintf makes this work for multiple threads.