Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write to stderr in ParseAPI::parsing_printf #1650

Merged
merged 6 commits into from
Dec 27, 2023
Merged

Write to stderr in ParseAPI::parsing_printf #1650

merged 6 commits into from
Dec 27, 2023

Commits on Dec 24, 2023

  1. Write to stderr in ParseAPI::parsing_printf 

    Using a per-thread file here is cumbersome. Including the thread id in
the message and synchronizing vprintf makes this work for multiple
threads.
    @hainest
    hainest committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    9d8c516 View commit details
    Browse the repository at this point in the history

  2. Disable clang's format-nonliteral warning 

    This is a contentious warning that was added to clang-15. See
(https://discourse.llvm.org/t/rfc-c-buffer-hardening/65734/85) for
details. Disable it for now.

This should be converted to a standard diagnostic suppression in
common/compiler_diagnostics.h.
    @hainest
    hainest committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    35cc2db View commit details
    Browse the repository at this point in the history

  3. Print to stderr 

    That was an inadvertent change.
    @hainest
    hainest committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    ef4f83d View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. flush stderr, not stdout

    @hainest
    hainest committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    f2f4227 View commit details
    Browse the repository at this point in the history

  2. Use a separate fprintf to avoid disabling clang warning

    @hainest
    hainest committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    bdc79ee View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Fix error handling in v/fprintf

    @hainest
    hainest committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    b65cad2 View commit details
    Browse the repository at this point in the history