RI-217: rejoint un groupe #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tu peux peut-être mettre juste un lien "rejoindre" |
|
dans ce cas là, si le nom de groupe est trop long ça ne sera pas très beau :/
vu que le top group list est assez etroit, ça serait sur deux lignes donc je suis partie sur une icone |
matthieuaudemard
requested changes
Dec 9, 2021
...end-implicaction/src/main/java/com/dynonuggets/refonteimplicaction/service/GroupService.java
Outdated
Show resolved
Hide resolved
backend-implicaction/src/main/java/com/dynonuggets/refonteimplicaction/service/UserService.java
Outdated
Show resolved
Hide resolved
...mplicaction/src/main/java/com/dynonuggets/refonteimplicaction/controller/UserController.java
Outdated
Show resolved
Hide resolved
...mplicaction/src/main/java/com/dynonuggets/refonteimplicaction/controller/UserController.java
Outdated
Show resolved
Hide resolved
...mplicaction/src/main/java/com/dynonuggets/refonteimplicaction/controller/UserController.java
Outdated
Show resolved
Hide resolved
...-implicaction/src/app/discussion/components/top-group-listing/top-group-listing.component.ts
Outdated
Show resolved
Hide resolved
...-implicaction/src/app/discussion/components/top-group-listing/top-group-listing.component.ts
Outdated
Show resolved
Hide resolved
...-implicaction/src/app/discussion/components/top-group-listing/top-group-listing.component.ts
Outdated
Show resolved
Hide resolved
matthieuaudemard
requested changes
Dec 11, 2021
...plicaction/src/main/java/com/dynonuggets/refonteimplicaction/controller/GroupController.java
Outdated
Show resolved
Hide resolved
backend-implicaction/src/main/java/com/dynonuggets/refonteimplicaction/service/UserService.java
Outdated
Show resolved
Hide resolved
* test en cours
* test done * renommage fichier subreddit en groupe * recherche par nom de groupe (champ unique et non nul)
* code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C'est une premiere ebauche, j'ai commencé à travailler sur pouvoir rejoindre un groupe depuis une discussion mais jsp si c'est compris dans la jira --> la subtilité c'est que l'ajout à partir du listing des meilleurs groupe se fait via l'id, mais depuis une discussion je ne récupère que le nom du groupe. Est ce que je me base sur le nom du groupe pour le listing des top groupes ?
Il faudrait aussi voir le css du bouton d'ajout, j'ai pas trouvé mieux (faut pas trop me demander de front)