Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup_local_symbol timekeeping_forward_now.constprop.8 (timekeeping.c) #228

Closed
jstancek opened this issue Jun 3, 2014 · 1 comment · Fixed by #230
Closed

lookup_local_symbol timekeeping_forward_now.constprop.8 (timekeeping.c) #228

jstancek opened this issue Jun 3, 2014 · 1 comment · Fixed by #230

Comments

@jstancek
Copy link
Contributor

jstancek commented Jun 3, 2014

I'm hitting this error, with following patch:

diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 1c5b0fc..aaee73f 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -474,6 +474,8 @@ void do_gettimeofday(struct timeval *tv)
 {
        struct timespec now;

+       if (!tv)
+               return;
        getnstimeofday(&now);
        tv->tv_sec = now.tv_sec;
        tv->tv_usec = now.tv_nsec/1000;
/usr/local/libexec/kpatch/create-diff-object: kpatch_create_patches_sections: 1490: lookup_local_symbol timekeeping_forward_now.constprop.8 (timekeeping.c)

# git log -p -1 --oneline
13f02e6 Merge pull request #224 from jpoimboe/distro-specific-vmlinux

# uname -r
3.10.0-123.el7.x86_64
@jpoimboe
Copy link
Member

jpoimboe commented Jun 3, 2014

Thanks @jstancek . This is very similar to #189, where gcc is renaming functions because of some compiler optimizations which affect the function's calling interface. The problem is that the trailing numbers don't match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants