Fix lock double-release.

The exclusive lock for from-JavaScript closure invocation was released twice when an exception was raised during evaluation.
dyoo · Feb 25, 2014 · 1625670 · 1625670
1 parent 04ce8e3
commit 1625670
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/whalesong/js-assembler/runtime-src/baselib-functions.js b/whalesong/js-assembler/runtime-src/baselib-functions.js
@@ -101,8 +101,7 @@
                         (succ || function () {}).apply(null, arguments); 
                     };
                     var wrappedFail = function(err) {
-                        releaseLock(); 
-                        (fail || function () {})(err); 
+                        (fail || function () {})(err);
                     };
                     if (!(baselib.arity.isArityMatching(v.racketArity, args.length - 2))) {
                         var msg = baselib.format.format(
@@ -159,8 +158,9 @@
                         MACHINE.v = oldVal;
                         MACHINE.a = oldArgcount;
                         MACHINE.p = oldProc;
+                        // The lock is released by _trampoline in this case.
                         wrappedFail(e);
-                    };  
+                    };
 
                     MACHINE._trampoline(v.label, false, releaseLock);
                 });