Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add target x64 install to package.json #224

Closed
polaroi8d opened this issue Sep 30, 2022 · 2 comments · Fixed by #227
Closed

Add target x64 install to package.json #224

polaroi8d opened this issue Sep 30, 2022 · 2 comments · Fixed by #227
Labels
issue:good first issue Good for newcomers issue:hacktoberfest Issue marked as suitable for Hacktoberfest issue:improvement Issue that makes something better. lang:typescript source:web The scope of the issue or pull request is web.

Comments

@polaroi8d
Copy link
Collaborator

We are using grpc-node and they don't have a precompiled ARM binary. So if you are trying to install the crux-ui component from the code repository, you have to add a --target_arch=x64 flag. Please create a new install script eg.: install:x64 with the mentioned flag.

package.json location: web/crux-ui/package.json

Information about the issue and the solution: grpc/grpc-node#1405
@polaroi8d polaroi8d added issue:good first issue Good for newcomers issue:improvement Issue that makes something better. issue:hacktoberfest Issue marked as suitable for Hacktoberfest labels Sep 30, 2022
@princefishthrower
Copy link
Contributor

@polaroi8d I can take this!

princefishthrower added a commit to princefishthrower/dyrectorio that referenced this issue Sep 30, 2022
@princefishthrower
Fix for dyrector-io#224 - add install for x86 architecture
3f563cc
@princefishthrower princefishthrower mentioned this issue Sep 30, 2022
Merged
@polaroi8d
Copy link
Collaborator Author

Linked PR #227

@polaroi8d polaroi8d linked a pull request Oct 3, 2022 that will close this issue
fix(crux-ui): npm install target script #227
Merged
@polaroi8d polaroi8d changed the title Add target x86 install to package.json Add target x64 install to package.json Oct 4, 2022
@polaroi8d polaroi8d added source:web The scope of the issue or pull request is web. lang:typescript labels Oct 4, 2022
polaroi8d pushed a commit to princefishthrower/dyrectorio that referenced this issue Oct 18, 2022
@princefishthrower @polaroi8d
Fix for dyrector-io#224 - add install for x86 architecture
a5eeff5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue:good first issue Good for newcomers issue:hacktoberfest Issue marked as suitable for Hacktoberfest issue:improvement Issue that makes something better. lang:typescript source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(crux-ui): npm install target script princefishthrower/dyrectorio
2 participants
@polaroi8d @princefishthrower