Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded URL in Rocket.Chat notifications #929

Closed
nandor-magyar opened this issue Mar 4, 2024 · 1 comment
Closed

Hardcoded URL in Rocket.Chat notifications #929

nandor-magyar opened this issue Mar 4, 2024 · 1 comment

Comments

@nandor-magyar
Copy link
Contributor

nandor-magyar commented Mar 4, 2024

At present, if one uses the Rocket.Chat notifications the URL is hardcoded and points to our landing page. For self-hosted scenarios, this is not ideal.

It should at least use the given domain configuration, from the configService.
Also from usability perspective, the message should be extended with a "source-link".

//...
"attachments": [{
   "color": color,
    "fields": [
      {
        "short": true,
        "title": "New Deployment",
        "value": "[Open deployment](" + ${sourceURL} + ")"
      },
//...

Related PR: #867

@polaroi8d
Copy link
Collaborator

PR merged, closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants