feat(web): integrate rocket.chat #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent notification system
robot9706
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Great work, I've tested it with a local rocket chat instance and it works fine.
There's one other thing though: You modified the database schema so please add a migration script as well, you can do it using npx prisma migrate dev.
Also please read the CONTRIBUTING.md, because the name of your PR is not valid.
|
can you please check now @robot9706 |
robot9706
changed the title
Linter is still failing. |
robot9706
approved these changes
Oct 31, 2023
|
fixes #234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It integrates the Rocket.Chat webhook to current notification system.
And fixes the bug in the deployment by fixing the NotificationMessageTypes to align exactly with the file names in the
web/crux/assets/notificationTemplates