only mount docker volumes on deploy #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dyson ping. thoughts on this? |
|
Awesome thanks for this. I'll be deploying a new site using an updated dokku this weekend so will have a close look at this and see what issues I run into. This will have implications for my https://github.com/dyson/dokku-docker-options plugin as well. |
dyson
added a commit
that referenced
this pull request
Jan 29, 2015
Don't mount docker volumes on build phase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the other PR. Accidentally opened from my master branch.
A few days ago dokku added running
dokku-argsplugins for thebuildphase. This seems to have caused an issue with (at least) heroku-buildpack-python. (ref: dokku/dokku#906)Additionally,
dokkunow callsdocker-argsplugins with a build phase passed as an argument. See: https://github.com/progrium/dokku/blob/fb3492c8242521dec4ed8428983ea752db710f86/dokku#L87This patch will only mount volumes if we get the deploy call. This is tested in my previously broken environments.
This seems to also cause an issue later on in the pipeline with
/build/builder:https://github.com/progrium/buildstep/blob/091eafdad7ccf5f4584aa21704397fd1dc1fd208/builder/builder#L70