Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][dcli] Init again #117 #127

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

[WIP][dcli] Init again #117 #127

wants to merge 27 commits into from

Conversation

at15
Copy link
Member

@at15 at15 commented Mar 31, 2020 •
edited

#117

  • sub command
  • flags
  • persistent flags

@at15 at15 added this to the 0.0.14 milestone Mar 31, 2020
@at15 at15 changed the title [WIP][dcli] Init [WIP][dcli] Init again #117 Mar 31, 2020
@codecov
Copy link

codecov bot commented Mar 31, 2020 •
edited

Codecov Report

Merging #127 into master will decrease coverage by 3.30%.
The diff coverage is 22.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   52.60%   49.30%   -3.31%     
==========================================
  Files          64       68       +4     
  Lines        2456     2572     +116     
==========================================
- Hits         1292     1268      -24     
- Misses       1043     1190     +147     
+ Partials      121      114       -7
Impacted Files Coverage Δ
errors/multi.go 79.79% <0.00%> (-3.36%) ⬇️
errors/pkg.go 100.00% <ø> (ø)
generator/gotmpl.go 0.00% <0.00%> (-12.13%) ⬇️
generator/pkg.go 0.00% <ø> (ø)
httpclient/client.go 43.16% <ø> (ø)
httpclient/context.go 45.23% <ø> (+5.65%) ⬆️
httpclient/method.go 80.00% <0.00%> (-20.00%) ⬇️
httpclient/option.go 42.85% <0.00%> (-7.15%) ⬇️
util/fsutil/file.go 0.00% <0.00%> (ø)
util/fsutil/ignore.go 78.37% <ø> (-3.61%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c784c...fef6316. Read the comment docs.

at15 added 12 commits April 2, 2020 15:36
@at15
[util] Use goimports when formatting generated go code
c976d78 
- The downside of it is introducing x/tools/imports and drags in many
  more dependencies including goldenmark, is used by present (generating
slide from markdown)
@at15
[dcli] Add buildinfo and default vars for ldflags
f37b3bd 
- `make install2` will install gommon2 and inject build info using
  ldflags
@at15
[fsutil] Add ignore pattern that accepts all
1a29436
@at15
[dcli] Init Command interface and default impl
1222f6c
@at15
[hashutil] Add fnv32a for pm
ebd3423
@at15
[httpclient] Add PUT
2d5761f
@at15
[dcli] Add command dispatch w/o flag and arguments
cb020cd
@at15
[fsutil] Add CreateFileAndPath
dce6d07
@at15
[genutil] Add SnakeToCamel
caee3c8
@at15
[doc] Add developer log and init empty milestones
7d51fb0
@at15
[doc][milestone] Add linter
da1d6e4
@at15
[gommon] Add gommon format #118
6dedbfc
@at15 at15 mentioned this pull request Aug 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg/dcli status/working type/new-package
Projects
None yet
Milestone
0.0.14
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@at15