Skip to content

Commit

Permalink
[fix] Don't drop query variables on handshake (socketio#2745)
Browse files Browse the repository at this point in the history
Parameters passed during handshake, such as tokens, were being dropped.
  • Loading branch information
perrin4869 authored and darrachequesne committed Nov 16, 2016
1 parent 2493aa2 commit ae212a3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 11 deletions.
9 changes: 2 additions & 7 deletions lib/socket.js
Expand Up @@ -8,6 +8,7 @@ var parser = require('socket.io-parser');
var url = require('url');
var debug = require('debug')('socket.io:socket');
var hasBin = require('has-binary');
var assign = require('object-assign');

/**
* Module exports.
Expand Down Expand Up @@ -110,13 +111,7 @@ Socket.prototype.buildHandshake = function(query){
function buildQuery(){
var requestQuery = url.parse(self.request.url, true).query;
//if socket-specific query exist, replace query strings in requestQuery
if(query){
query.t = requestQuery.t;
query.EIO = requestQuery.EIO;
query.transport = requestQuery.transport;
return query;
}
return requestQuery || {};
return assign({}, query, requestQuery);
}
return {
headers: this.request.headers,
Expand Down
9 changes: 5 additions & 4 deletions package.json
Expand Up @@ -24,12 +24,13 @@
"test": "gulp test"
},
"dependencies": {
"debug": "2.2.0",
"engine.io": "1.7.2",
"socket.io-parser": "2.3.1",
"socket.io-client": "1.5.1",
"socket.io-adapter": "0.4.0",
"has-binary": "0.1.7",
"debug": "2.2.0"
"object-assign": "4.1.0",
"socket.io-adapter": "0.4.0",
"socket.io-client": "1.5.1",
"socket.io-parser": "2.3.1"
},
"devDependencies": {
"babel-preset-es2015": "6.3.13",
Expand Down

0 comments on commit ae212a3

Please sign in to comment.