Don't drop query variables on handshake

[perrin4869]

The kind of change this PR does introduce

• a bug fix
• a new feature
• an update to the documentation
• a code change that improves performance
• other

Current behaviour

Right now parameters passed during handshake, such as tokens, are being dropped.

New behaviour

Parameters are preserved as intended

Other information (e.g. related issues)

Fixes #2712

[darrachequesne]

Could you please pin the dependency here please?

[perrin4869]

Done! Missed it sorry!

[jasperck]

Hi, just wanna ask why require object-assign usage rather than native object.assign,
is there any issue about shallow/deep clone? or just because the polyfill

[perrin4869]

@jasperck node 0.10 and 0.12 are still being supported and they don't have native Object.assign. You can check Travis build logs, my first commit here used the native one and it passed for node 4 and 6 but failed for the older node... Hence why I introduced the polyfill. Maybe a note should be made to remove the dependency once node older than 4.0 stops being supported.

[jasperck]

@perrin4869 Thanks for the feedback. Yep I saw the build and got it now. Adding a note for removing the dependency in the future sounds good.

[perrin4869]

@jasperck maybe opening an issue as a remainder might do it, but considering the number of open issues right now, it would just get buried and forgotten...
@darrachequesne not to sound too impatient, but can we expect a patched release sometime soon? Thanks!

[mck-]

Yes please! This is breaking for us too 😄

[darrachequesne]

1.6.0 is out!

Regarding node 0.10 and 0.12, I think we'll deprecate those version in the next major bump (which will be eventually needed if we want to update ws).

[mck-]

Excellent – thanks! I'll test it later today 👍 that was very fast 👏

[mck-]

Works great 👌