Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: forbid using relative imports across the repo #493

Merged
merged 8 commits into from
Sep 17, 2022
Merged

Chore: forbid using relative imports across the repo #493

merged 8 commits into from
Sep 17, 2022

Conversation

ZibanPirate
Copy link
Member

Description

Type of change

  • Refactoring

@ZibanPirate ZibanPirate self-assigned this Sep 17, 2022
@ZibanPirate ZibanPirate linked an issue Sep 17, 2022 that may be closed by this pull request
forbid using relative imports across the repo #492
Closed
@github-actions github-actions bot added api API related changes ( api folder ) data Data related changes ( data folder ) mobile Mobile related changes ( mobile folder ) models models package tooling tooling package ui ui package utils utils package web Web related changes ( web folder ) labels Sep 17, 2022
@ZibanPirate ZibanPirate requested a review from a team September 17, 2022 13:47
omdxp
omdxp reviewed Sep 17, 2022
View reviewed changes
Copy link
Member

@omdxp omdxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an error with the deploy action:

Error: Specified "public" directory "public" does not exist, can't deploy hosting to site "staging-dzcode-io"

@ZibanPirate
Copy link
Member Author

the actual issue happened a bit earlier
https://github.com/dzcode-io/dzcode.io/actions/runs/3073564402/jobs/4965779877#step:8:35

it's now fixed, and the stage looking good on stg-v4.0.4-pr493.1

@ZibanPirate ZibanPirate merged commit e9aa424 into main Sep 17, 2022
@ZibanPirate ZibanPirate deleted the 492-forbid-using-relative-imports-across-the-repo branch September 17, 2022 17:18
@ZibanPirate ZibanPirate mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omdxp omdxp omdxp approved these changes

Assignees

@ZibanPirate ZibanPirate

Labels
api API related changes ( api folder ) data Data related changes ( data folder ) mobile Mobile related changes ( mobile folder ) models models package tooling tooling package ui ui package utils utils package web Web related changes ( web folder )
Projects
DzCode i/o
Status: Released
Milestone
Developer experience Improvement
Development

Successfully merging this pull request may close these issues.

forbid using relative imports across the repo
2 participants
@ZibanPirate @omdxp