New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docker image #117
Comments
Fair point, at this moment the entrypoint is just hardcoded 🤡 Line 24 in 0b0c7d6
|
I develop a lot of public and private projects simultaneously and it helps me to keep it clean. The issue received a potential fix and in most cases that's enough - also a lot of people just won't even respond in the future. I don't have time to review these issues again and again, in case of any need I can just reopen a thread. And as I see that's your case :) |
I've received feedback about some issues related to the current Dockerfile and it's why I had to take action, because current thread was opened for almost a month without any specifics . Details about changes in Dockerfile and build lifecycle:
These changes will be available in 2.7.0. In case of any new suggestions, report them in a new issue. |
It is normal that people has other things to do :) In case of any new thoughts, just report a new issue. |
Hi @dzikoysk
Tried to run via docker and experienced following issues I'd like to share with
Although README shows an example of overriding params via
JAVA_OPTS
, in reality passingJAVA_OPTS
via-e
option doesn't do anything, since this variable is not passed tojava
inENTRYPOINT
instruction ( i just tried to override Xms , port ) and actual docker always ignored the value.Dockerfile builds app from source, while it could just use a jar that is published to
Releases
and located in repoIn fact, I'm interested to try this software in docker and could countribute improved Dockerfile if you're interested.
The text was updated successfully, but these errors were encountered: