Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docker image #117

Closed
eshepelyuk opened this issue Jun 17, 2020 · 4 comments
Closed

Improve docker image #117

eshepelyuk opened this issue Jun 17, 2020 · 4 comments
Assignees
Labels
enhancement Improvement of existing feature request

Comments

@eshepelyuk
Copy link

Hi @dzikoysk

Tried to run via docker and experienced following issues I'd like to share with

  • Although README shows an example of overriding params via JAVA_OPTS, in reality passing JAVA_OPTS via -e option doesn't do anything, since this variable is not passed to java in ENTRYPOINT instruction ( i just tried to override Xms , port ) and actual docker always ignored the value.

  • Dockerfile builds app from source, while it could just use a jar that is published to Releases and located in repo

In fact, I'm interested to try this software in docker and could countribute improved Dockerfile if you're interested.

@dzikoysk dzikoysk added the bug Bugs & errors found in Reposilite label Jun 17, 2020
@dzikoysk
Copy link
Owner

dzikoysk commented Jun 17, 2020

Fair point, at this moment the entrypoint is just hardcoded 🤡

ENTRYPOINT [ "java", "-Xmx128M", "-jar", "reposilite.jar"]

JAVA_OPTS should be passed to the entrypoint ENTRYPOINT exec java $JAVA_OPTS. I'm not familiar with Docker and I'm open for your contributions to improve this area.

@dzikoysk dzikoysk added the in progress Issue is currently being processed label Jun 17, 2020
@dzikoysk dzikoysk self-assigned this Jun 17, 2020
@dzikoysk dzikoysk removed the in progress Issue is currently being processed label Jun 18, 2020
@dzikoysk
Copy link
Owner

dzikoysk commented Jun 19, 2020

I develop a lot of public and private projects simultaneously and it helps me to keep it clean. The issue received a potential fix and in most cases that's enough - also a lot of people just won't even respond in the future. I don't have time to review these issues again and again, in case of any need I can just reopen a thread.

And as I see that's your case :)

@dzikoysk dzikoysk reopened this Jun 19, 2020
@dzikoysk dzikoysk added the enhancement Improvement of existing feature request label Jun 19, 2020
@dzikoysk dzikoysk removed their assignment Jun 22, 2020
@dzikoysk dzikoysk removed the bug Bugs & errors found in Reposilite label Jun 29, 2020
@dzikoysk dzikoysk changed the title Issues with docker Improve docker image Jun 29, 2020
@dzikoysk dzikoysk self-assigned this Jul 11, 2020
@dzikoysk dzikoysk added the in progress Issue is currently being processed label Jul 11, 2020
@dzikoysk dzikoysk removed the in progress Issue is currently being processed label Jul 12, 2020
@dzikoysk
Copy link
Owner

dzikoysk commented Jul 12, 2020

I've received feedback about some issues related to the current Dockerfile and it's why I had to take action, because current thread was opened for almost a month without any specifics . Details about changes in Dockerfile and build lifecycle:

These changes will be available in 2.7.0. In case of any new suggestions, report them in a new issue.

@dzikoysk
Copy link
Owner

It is normal that people has other things to do :) In case of any new thoughts, just report a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature request
Projects
None yet
Development

No branches or pull requests

2 participants