Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository details incorrectly constructed xml tags #1619

Closed
IM-IgniteDEV opened this issue Oct 22, 2022 · 4 comments · Fixed by #1620
Closed

Repository details incorrectly constructed xml tags #1619

IM-IgniteDEV opened this issue Oct 22, 2022 · 4 comments · Fixed by #1620
Labels
bug Bugs & errors found in Reposilite cosmetic Issue is not harmful and affects only cosmatic part of a project good first issue It would be great, if this issue could be solved by community

Comments

@IM-IgniteDEV
Copy link

What happened?

In the overview on our repository dashboard we can see small "Repository Details" section, currently generated tags look like this:

<repository> <id><id/> <name><name/> <url><url/> <repository/>

that's incorrect construction, accepted syntax looks like this:

<repository> <id></id> <name></name> <url></url> </repository>

as you can notice, the only difference between these two examples is "/" contained in the closing tag, reposilite generated example is placing that slash in the wrong place.

Reposilite version

3.x

Relevant log output

No response

@IM-IgniteDEV IM-IgniteDEV added the bug Bugs & errors found in Reposilite label Oct 22, 2022
@dzikoysk dzikoysk added cosmetic Issue is not harmful and affects only cosmatic part of a project good first issue It would be great, if this issue could be solved by community labels Oct 22, 2022
@joshuasing
Copy link
Sponsor Contributor

I may have misread this, or may not be understanding, but this looks like the second example you provide:
https://github.com/dzikoysk/reposilite/blob/main/reposilite-frontend/src/helpers/maven/repository.js#L40-L44

I cannot seem to find the snippet that you are referring to 🤔

@joshuasing
Copy link
Sponsor Contributor

I just checked my repository and they also seem to display like this, although I cannot figure out why the / is moved to the end
image

@IM-IgniteDEV
Copy link
Author

image

@joshuasing
Copy link
Sponsor Contributor

joshuasing commented Oct 22, 2022

I think I found the problem, it looks to be caused by this line:
https://github.com/dzikoysk/reposilite/blob/main/reposilite-frontend/src/components/card/XmlTag.vue#L29

which was introduced in #1550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs & errors found in Reposilite cosmetic Issue is not harmful and affects only cosmatic part of a project good first issue It would be great, if this issue could be solved by community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants