Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-937 Update S3 client #936

Merged
merged 8 commits into from Nov 22, 2021
Merged

GH-937 Update S3 client #936

merged 8 commits into from Nov 22, 2021

Conversation

envomp
Copy link
Contributor

@envomp envomp commented Nov 22, 2021

S3 client change accessKey, secretKey, region to optional parameters, so users can use default configuration provided by AWS
S3 storage provider create bucket if it's missing only

@envomp envomp marked this pull request as draft November 22, 2021 14:03
@dzikoysk dzikoysk changed the title Update S3 client GH-937 Update S3 client Nov 22, 2021
@dzikoysk dzikoysk linked an issue Nov 22, 2021 that may be closed by this pull request
@envomp envomp marked this pull request as ready for review November 22, 2021 17:19
@dzikoysk
Copy link
Owner

Thanks for your contribution! ❤️

@dzikoysk dzikoysk merged commit f00a15f into dzikoysk:main Nov 22, 2021
dzikoysk pushed a commit that referenced this pull request Jul 8, 2022
* MDP-1259: Zeppelin + reposilite PoC

* reorder params

* update documentation and tests

* Junit test fix - add missing prefixes

Co-authored-by: evompa <evompa@twilio.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve S3 configuration and initialization
2 participants