Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(section): add name and displayname fields to section data #195

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

Dramaturco
Copy link
Contributor

This pull request resolves issue #194

Copy link
Collaborator

@nico-mcalley nico-mcalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it worked fine.
In general I'd approve, but please have a look if we need to make name and display name optional.

src/types.ts Outdated Show resolved Hide resolved
@nico-mcalley nico-mcalley merged commit cc9e470 into master Nov 9, 2023
3 checks passed
@nico-mcalley nico-mcalley deleted the feature/add-reference-name-to-section branch November 9, 2023 16:08
github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
# [10.19.0](v10.18.2...v10.19.0) (2023-11-09)

### Features

* **section:** add name and displayname fields to section data  ([#195](#195)) ([cc9e470](cc9e470))
Copy link

github-actions bot commented Nov 9, 2023

🎉 This PR is included in version 10.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants