Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo cause regression: missing s25 output #873

Closed
gluesmith2021 opened this issue Nov 8, 2023 · 1 comment · Fixed by #874
Closed

typo cause regression: missing s25 output #873

gluesmith2021 opened this issue Nov 8, 2023 · 1 comment · Fixed by #874
Assignees
Labels
bug Something isn't working Core modules (Sxx) The core scanning modules (Sxx modules) EMBA

Comments

@gluesmith2021
Copy link

Describe the bug

s25 module stops printing output if it has to print WARNING: Vulnerability CVE-... is a known exploited vulnerability. Then, the rest of the output goes missing in s25_kernel_check.txt, and no html version is produced at all.

Identified cause: on the brace-your-variables-winter-is-coming commit 22ce0d9, line 219 contains ${GREEN }Vulnerability while it should be ${GREEN} Vulnerability.

As a side-issue, perhaps also related to the braces storm, but couldn't figure out the cause: items of "Kernel details" now end with an extra brace, such as:

Kernel details:
    USB_2_0__Enhanced__Host_Controller__EHCI__Driver}
    sample_ext_module}

This is only a cosmetic inconvenience, as opposed to the missing s25 output.

To Reproduce

Typical EMBA installation, analyze an image with a known exploited vulnerability among kernel modules.

Desktop
OS: dedicated Ubuntu 22.04 VM
EMBA version: master branch, commit af02844
Installation method: default with up to date docker image

Priority issue
Are you already a [Sponsor]? N

@m-1-k-3 m-1-k-3 self-assigned this Nov 8, 2023
@m-1-k-3 m-1-k-3 added bug Something isn't working Core modules (Sxx) The core scanning modules (Sxx modules) EMBA labels Nov 8, 2023
m-1-k-3 added a commit to m-1-k-3/emba that referenced this issue Nov 8, 2023
@m-1-k-3 m-1-k-3 mentioned this issue Nov 8, 2023
@m-1-k-3
Copy link
Member

m-1-k-3 commented Nov 8, 2023

Thank you for reporting this issue ... PR is waiting for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Core modules (Sxx) The core scanning modules (Sxx modules) EMBA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants