Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S15 - improve variable handling #1059

Merged
merged 8 commits into from Feb 29, 2024
Merged

S15 - improve variable handling #1059

merged 8 commits into from Feb 29, 2024

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Feb 29, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

Module logging is inconsistent and logs are in some cases in the wrong log file - see #1054 (comment)

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

better, but fixed?!?

@m-1-k-3 m-1-k-3 added bug Something isn't working Core modules (Sxx) The core scanning modules (Sxx modules) EMBA labels Feb 29, 2024
@torabi12
Copy link

I tried these:

$ git remote add s15_logging https://github.com/m-1-k-3/emba
$ git fetch s15_logging
$ git checkout s15_logging

maybe some part is good but I am not using s15_logging.

This one is not OK:

$ git clone https://github.com/m-1-k-3/emba.git -b s15_logging                                                                                                                                                             
fatal: destination path 'emba' already exists and is not an empty directory.

@m-1-k-3
Copy link
Member Author

m-1-k-3 commented Feb 29, 2024

$ git clone https://github.com/m-1-k-3/emba.git -b s15_logging                                                                                                                                                             
fatal: destination path 'emba' already exists and is not an empty directory.

This one should work:

git clone -b s15_logging https://github.com/m-1-k-3/emba.git emba_s15

@torabi12
Copy link

Your command was working, thank you!

I got this at the beginning:

image

but I went on and the scan is running. It was a long one, I think we will have result early evening.

@m-1-k-3
Copy link
Member Author

m-1-k-3 commented Feb 29, 2024

are you in the right directory? You need to do a cd emba_s15

@torabi12
Copy link

torabi12 commented Feb 29, 2024

Sorry, I was in wrong dir. I tried in the good one, but python stopped me:

image

:(

I try it on a clean system again, it will work I think....

@m-1-k-3
Copy link
Member Author

m-1-k-3 commented Feb 29, 2024

Sorry, I was in wrong dir. I tried in the good one, but python stopped me:

I think it should be fine to link your already installed external directory to the new one

@torabi12
Copy link

The test finally started. :)

@torabi12
Copy link

torabi12 commented Feb 29, 2024

kép

the scan is still going, I just caught these lines.

@m-1-k-3 m-1-k-3 merged commit ad959c2 into e-m-b-a:master Feb 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Core modules (Sxx) The core scanning modules (Sxx modules) EMBA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants