-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restart EMBA functionality #1078
Conversation
Ok so that did not completely solve the problem. If we consider the profile full and final and something was terminated, the string "Test ended" would not be there and check_emba_ended() would not return true and restart ensues. But, if the analyst incrementally changes the profile, we have a problem. For example, in my profile I had everything black listed except the P02 -- cause I wanted to just see the initial analysis and make my choices after that. In this case, the analysis obviously finished successfully and "Test ended" was logged at the end of the log file
Next time, when I enabled the corresponding extraction/unpacking module etc. the restart would fail. As such, the differential restart requirement was raised in #1073. That is, at this point, if I replied to using "n" at the log deletion prompt EMBA would terminate because check_emba_ended() would not correctly indicate that emba has NOT_FINISHED in the log_folder() function. |
Currently the way I am handling this is by exporting a KEEP_GOING=1 variable in my profile file and making two changes
Now it works. |
But ideally we should the following
|
fine, this is the idea of this functionality.
You could remove the "Test ended" entry in the log file via sed or so.
Yes, if the test is ended then the current functionality does not cover your use case and you need to adjust emba.log or log to a new log directory or overwrite the current log. |
ad 2 - As the complete rescan feature is not that well tested I would not do it as default but we can introduce your approach you have shown in here #1078 (comment) |
Bug fix
see #1077 and #1073
the original "buggy" restart functionality should be recovered
closes #1077