Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vars check #1126

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Vars check #1126

merged 5 commits into from
Apr 12, 2024

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Apr 12, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

fix another 100 bugs

  • What is the current behavior? (You can also link to an open issue here)

l10 has a lot of variables as indirect exports.

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

declared all vars as exported or local in l10

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

all modules are now compliant.
Check-script includes this check now for the modules
Todo: Helpers

  • Other information:

@m-1-k-3 m-1-k-3 added bug Something isn't working enhancement New feature or request System emulator (Lxx) The system emulator (Lxx modules) EMBA labels Apr 12, 2024
@BenediktMKuehne BenediktMKuehne merged commit 8dd3493 into e-m-b-a:master Apr 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenediktMKuehne BenediktMKuehne BenediktMKuehne approved these changes

Assignees
No one assigned
Labels
bug Something isn't working EMBA enhancement New feature or request System emulator (Lxx) The system emulator (Lxx modules)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m-1-k-3 @BenediktMKuehne