Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan profile support #120

Merged
merged 3 commits into from Jun 15, 2021
Merged

Scan profile support #120

merged 3 commits into from Jun 15, 2021

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Jun 9, 2021

As emba grows and we have more and more options that you need to set for getting the best results from emba I started to include a simple profile handling.

You can use this for example in the following way:

└─$ sudo ./emba.sh -l ../emba_logs/logs_dir300 -f ../testimages/DIR300B5_FW214WWB01.bin -p default-scan-docker.emba

Currently I have included the following profiles:

└─$ ls ./scan-profiles   
default-scan-docker.emba  default-scan.emba  full-scan_docker.emba  full-scan.emba

In the future we could probably include profiles like "quick-scan.emba" where we disable long running modules like S09 or S115. Another profile could be "vulnerability-detection.emba" where we only execute S09, S25 and S115.

@m-1-k-3 m-1-k-3 added the enhancement New feature or request label Jun 9, 2021
@m-1-k-3 m-1-k-3 mentioned this pull request Jun 10, 2021
16 tasks
@m-1-k-3 m-1-k-3 changed the title profiles - initial commit Scan profile support Jun 13, 2021
@m-1-k-3 m-1-k-3 marked this pull request as ready for review June 13, 2021 10:58
@m-1-k-3 m-1-k-3 requested a review from p4cx June 13, 2021 10:58
@p4cx
Copy link
Member

p4cx commented Jun 14, 2021

I would like to be able to add a profile as a path:

sudo ./emba.sh -f ./../fw -l ./../log -p ./scan-profiles/default-scan-docker.emba 

[...]

[!] Profile ./scan-profiles/./scan-profiles/default-scan-docker.emba not found.

As path, I can use the text auto complete functionality of my terminal - so I don't have to remember the names of the profiles.

scan-profiles/full-scan_docker.emba Outdated Show resolved Hide resolved
@p4cx p4cx merged commit da2ddd4 into e-m-b-a:master Jun 15, 2021
@m-1-k-3 m-1-k-3 deleted the profiles branch June 24, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants