Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove broken code #176

Merged
merged 7 commits into from
Nov 8, 2021
Merged

Remove broken code #176

merged 7 commits into from
Nov 8, 2021

Conversation

p4cx
Copy link
Member

@p4cx p4cx commented Nov 8, 2021

Fix #174 - there is a check, if the files are valid and it was broken. But we are checking in the modules, if the paths are valid (if -d or -f). Remove it, now it works :)

@p4cx p4cx marked this pull request as draft November 8, 2021 11:13
@p4cx p4cx requested a review from m-1-k-3 November 8, 2021 13:08
@p4cx p4cx marked this pull request as ready for review November 8, 2021 13:09
m-1-k-3
m-1-k-3 approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@m-1-k-3 m-1-k-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@m-1-k-3 m-1-k-3 merged commit 5bc2275 into master Nov 8, 2021
@p4cx p4cx deleted the fix_mod_path branch November 8, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-1-k-3 m-1-k-3 m-1-k-3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files not found by 50_authentication_check
2 participants
@p4cx @m-1-k-3