Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net change #183

Merged
merged 23 commits into from
Nov 25, 2021
Merged

Net change #183

merged 23 commits into from
Nov 25, 2021

Conversation

BenediktMKuehne
Copy link
Member

just changing the networking method for better isolation

@BenediktMKuehne BenediktMKuehne marked this pull request as draft November 22, 2021 13:38
@BenediktMKuehne
Copy link
Member Author

depends on other-changes to the cve-db checks

@m-1-k-3
Copy link
Member

m-1-k-3 commented Nov 22, 2021

I will initiate the PR for the cve-db checks today

@m-1-k-3 m-1-k-3 mentioned this pull request Nov 22, 2021
Merged
@m-1-k-3 m-1-k-3 marked this pull request as ready for review November 23, 2021 16:52
@BenediktMKuehne BenediktMKuehne marked this pull request as draft November 24, 2021 10:17
@BenediktMKuehne BenediktMKuehne marked this pull request as ready for review November 24, 2021 11:47
m-1-k-3
m-1-k-3 reviewed Nov 24, 2021
View reviewed changes
installer.sh Outdated Show resolved Hide resolved
@BenediktMKuehne
Copy link
Member Author

With these changes we accomplished the isolation of the EMBA-container.
The only connection between the Host and Container is 172.36.0.1:27017 on the Interface "emba_runs" where the cve_search-mongodb is running.
This config is now static (in external/cve_search/etc/configuration.ini, /etc/mongod.conf and docker-compose).

!I am tracking a problem with the interface where the static ip (172.36.0.1) is not always addressable after reboot.!

m-1-k-3
m-1-k-3 approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@m-1-k-3 m-1-k-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. The container is already updated and we should be ready to go

@m-1-k-3 m-1-k-3 merged commit b83444c into e-m-b-a:master Nov 25, 2021
@m-1-k-3 m-1-k-3 mentioned this pull request Nov 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-1-k-3 m-1-k-3 m-1-k-3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BenediktMKuehne @m-1-k-3