Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misquoted variable $SEARCH_LOC breaking find command #29

Closed
wants to merge 1 commit into from

Conversation

elig0n
Copy link

@elig0n elig0n commented Jan 16, 2021

the path-holding variable $SEARCH_LOC was not quoted thus breaking the find command on paths that contain spaces

the path-holding variable $SEARCH_LOC was not quoted thus breaking the find command on paths that contain spaces
@m-1-k-3 m-1-k-3 added the bug Something isn't working label Jan 17, 2021
@m-1-k-3
Copy link
Member

m-1-k-3 commented Jan 17, 2021

Thanks for pointing us on this issue. We should move to real Arrays in multiple areas.
A quick check points more than 50 areas where we iterate this way.

└─$ grep for.*\;\ do modules/* -R | grep -v "{" | wc -l
56

As your current fix will possibly break stuff I will open an issue where we can document all the usages of this type of iteration and we can move to real arrays.

@m-1-k-3 m-1-k-3 mentioned this pull request Jan 17, 2021
@m-1-k-3
Copy link
Member

m-1-k-3 commented Jan 17, 2021

Issue opened #30 - closing here
Thanks @elig0n for finding this problem

@m-1-k-3 m-1-k-3 closed this Jan 17, 2021
m-1-k-3 pushed a commit that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants