Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit check to modules directory #300

Merged
merged 1 commit into from Sep 4, 2022
Merged

Limit check to modules directory #300

merged 1 commit into from Sep 4, 2022

Conversation

p4cx
Copy link
Member

@p4cx p4cx commented Sep 4, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Easy fix.

  • What is the current behavior? (You can also link to an open issue here)

@n0x08 created the issue #297 because after running EMBA with the log dir set inside the EMBA directory he found out, that the reference links to some other modules were wrong in the webreport.

Why? It is possible to add [REF] tags to modules in the output of EMBA and the webreport generation script checks then for the modules (previously in the main directory of EMBA with ignoring of the file ending) if they exists. There it found the old log files instead of the modules and linked to them and therefore created the mess.

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

No wrong links anymore if there are old log files in the EMBA directory.

Copy link
Member

@m-1-k-3 m-1-k-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the fix

@m-1-k-3 m-1-k-3 merged commit b7429b5 into master Sep 4, 2022
@p4cx p4cx deleted the fix_links_webreport branch September 5, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants