Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grepit and semgrep improvements #311

Merged
merged 3 commits into from Sep 24, 2022
Merged

Grepit and semgrep improvements #311

merged 3 commits into from Sep 24, 2022

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Sep 22, 2022 •
edited

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Sometimes grepit produces a huge amount of results
Make EMBA semgrep compatible
Further improvements to not disable shellcheck tests

@m-1-k-3 m-1-k-3 added the enhancement New feature or request label Sep 22, 2022
p4cx
p4cx reviewed Sep 23, 2022
View reviewed changes
Copy link
Member

@p4cx p4cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this PR - alone all the removals from the shellchecker exeptions. Going to test this also on my machine.

@p4cx p4cx merged commit 000755f into e-m-b-a:master Sep 24, 2022
@m-1-k-3 m-1-k-3 deleted the grepit branch September 26, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p4cx p4cx p4cx approved these changes

@BenediktMKuehne BenediktMKuehne Awaiting requested review from BenediktMKuehne

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m-1-k-3 @p4cx