Docker Integration #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option to use docker container directly in emba using -D.
m-1-k-3
requested changes
Jan 19, 2021
There was a problem hiding this comment.
I like your integration of docker into the basic emba command.
some short notes:
- Could you please add a short parameter description in the help output
- In my tests I had some issues with parameters. For example I got an error with the following combination:
./emba.sh -z -s -l ./logs_dwr-118 -f /home/m1k3/git-repos/testimages/testimages/testimages/DWR-118_RevA_Firmware101b02.bin -D
=> results in the following error:
./emba.sh: illegal option -- [-] Invalid option - Please include a check on docker-compose
Thanks for your contribution
emba.sh
Outdated
| done | ||
|
|
||
| print_output "[*] Emba initializes kali docker container." "no_log" | ||
| FIRMWARE="$FIRMWARE_PATH" LOG="$LOG_DIR" docker-compose run emba ./emba.sh -l /log/ -f /firmware/ "$ARGS" |
There was a problem hiding this comment.
Could you please do a check to ensure docker-compose is available on the host?
small improvements before merging
This was referenced Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to use docker container directly in emba using -D.