Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shellcheck disable cleanup #349

Merged
merged 2 commits into from Oct 17, 2022
Merged

shellcheck disable cleanup #349

merged 2 commits into from Oct 17, 2022

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Oct 15, 2022 •
edited

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Cleanup

  • What is the current behavior? (You can also link to an open issue here)

multiple shellcheck disable=SCxyz

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

multiple shellcheck disables replaced
Matrix mode removed

@m-1-k-3 m-1-k-3 added the bug Something isn't working label Oct 15, 2022
@m-1-k-3 m-1-k-3 changed the title shellcheck disable removed F20, S08 shellcheck disable cleanup Oct 15, 2022
@BenediktMKuehne BenediktMKuehne merged commit aae1121 into e-m-b-a:master Oct 17, 2022
@m-1-k-3 m-1-k-3 deleted the shellcheck_disable_cleanup branch October 30, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenediktMKuehne BenediktMKuehne BenediktMKuehne approved these changes

@p4cx p4cx Awaiting requested review from p4cx

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m-1-k-3 @BenediktMKuehne