Freetzng-fix #433
Merged
Freetzng-fix #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-1-k-3
reviewed
Dec 15, 2022
| chown -R freetzuser:freetzuser external/freetz-ng | ||
| chmod 777 -R external/freetz-ng | ||
| su freetzuser -c "git clone https://github.com/Freetz-NG/freetz-ng.git external/freetz-ng" | ||
| su - freetzuser -c "git clone https://github.com/Freetz-NG/freetz-ng.git /tmp/freetz-ng" |
There was a problem hiding this comment.
as we are using "$EXT_DIR"/freetz-ng/fwmod in the extractor this will not work.
There was a problem hiding this comment.
emba/modules/P12_avm_freetz_ng_extract.sh
Line 57 in 992947c
BenediktMKuehne
commented
Dec 15, 2022
| cd "$HOME_PATH" || ( echo "Could not install EMBA component Freetz-NG" && exit 1 ) | ||
| mv -r /tmp/freetz-ng/* external/freetz-ng/ |
There was a problem hiding this comment.
The end-result should be the same no?
There was a problem hiding this comment.
sorry but I have not seen this. Do we really need to build it in tmp?
There was a problem hiding this comment.
my understanding of different filesystems is limited, but this circumvents all permission problems with one user building in another ones home-directory
m-1-k-3
approved these changes
Dec 16, 2022
| cd "$HOME_PATH" || ( echo "Could not install EMBA component Freetz-NG" && exit 1 ) | ||
| mv -r /tmp/freetz-ng/* external/freetz-ng/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixes tool installation
What is the current behavior? (You can also link to an open issue here)
broken
What is the new behavior (if this is a feature change)? If possible add a screenshot.
fix
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
❎ no