Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s08 safe_echo fix #470

Merged
merged 1 commit into from Feb 7, 2023
Merged

s08 safe_echo fix #470

merged 1 commit into from Feb 7, 2023

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Feb 3, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

We started to refactor for using safe_echo instead of echo. This has some side effects. We need to evaluate the usage of safe_echo more in detail. This is a quick fix to get the module up again.

@m-1-k-3 m-1-k-3 added bug Something isn't working Core modules (Sxx) The core scanning modules (Sxx modules) labels Feb 3, 2023
@m-1-k-3 m-1-k-3 merged commit ccc1f54 into e-m-b-a:master Feb 7, 2023
@m-1-k-3 m-1-k-3 deleted the s08_echo_fix branch May 11, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenediktMKuehne BenediktMKuehne Awaiting requested review from BenediktMKuehne

Assignees
No one assigned
Labels
bug Something isn't working Core modules (Sxx) The core scanning modules (Sxx modules)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@m-1-k-3