Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables extraction, cve-search and cwe-checker in Docker container #49

Merged
merged 26 commits into from
Feb 15, 2021

Conversation

Anemosx
Copy link
Contributor

@Anemosx Anemosx commented Feb 8, 2021

Solve binwalk #37:

  • Emba can now extract firmware inside of docker containers

Solve cve-search #39:

cwe-checker #38 (NOT TESTED):

  • cwe-checker calls a new docker container from the host as a sibling container

@m-1-k-3 m-1-k-3 added the enhancement New feature or request label Feb 8, 2021
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
emba.sh Outdated Show resolved Hide resolved
@m-1-k-3
Copy link
Member

m-1-k-3 commented Feb 9, 2021

@Anemosx great pull request. This will be a massive step in our docker integration. Could you please check the comments. Afterwards I will proceed with testing. Thanks

installer.sh Show resolved Hide resolved
allows force installtion for binwalk and deps, also enables update of cve-search database in docker (updating db takes some time)
current version of docker emba does not support cwe-search (maybe in future), disables option and prints hint
@m-1-k-3 m-1-k-3 requested a review from p4cx February 15, 2021 11:21
@p4cx p4cx removed a link to an issue Feb 15, 2021
@p4cx p4cx linked an issue Feb 15, 2021 that may be closed by this pull request
Copy link
Member

@p4cx p4cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks really good - two little ideas, but that's just style. Still have to test that.

Dockerfile Outdated Show resolved Hide resolved
emba.sh Show resolved Hide resolved
@p4cx p4cx self-requested a review February 15, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cve-search support in docker CWE-checker support in docker Binwalk support in docker
3 participants