-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables extraction, cve-search and cwe-checker in Docker container #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge head
enables cve-search in docker container using the existing host mongodb
This was
linked to
issues
Feb 8, 2021
m-1-k-3
reviewed
Feb 9, 2021
m-1-k-3
reviewed
Feb 9, 2021
m-1-k-3
reviewed
Feb 9, 2021
@Anemosx great pull request. This will be a massive step in our docker integration. Could you please check the comments. Afterwards I will proceed with testing. Thanks |
Use return value of docker-compose for check
move apt installs and cve-search install to installer
p4cx
reviewed
Feb 11, 2021
allows force installtion for binwalk and deps, also enables update of cve-search database in docker (updating db takes some time)
current version of docker emba does not support cwe-search (maybe in future), disables option and prints hint
p4cx
reviewed
Feb 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks really good - two little ideas, but that's just style. Still have to test that.
p4cx
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve binwalk #37:
Solve cve-search #39:
Enables the cve-search inside of docker containers
cve-search in docker container uses the host database
Prerequisite: Populate database on the host machine (see https://github.com/e-m-b-a/emba/wiki/Aggregator)
cwe-checker #38 (NOT TESTED):