Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer cve search database #67

Merged
merged 12 commits into from
Mar 12, 2021
Merged

Installer cve search database #67

merged 12 commits into from
Mar 12, 2021

Conversation

Anemosx
Copy link
Contributor

@Anemosx Anemosx commented Mar 9, 2021

Emba installer downloads cve serach database:

@m-1-k-3 m-1-k-3 added the enhancement New feature or request label Mar 9, 2021
@m-1-k-3 m-1-k-3 self-requested a review March 9, 2021 15:27
@m-1-k-3
Copy link
Member

m-1-k-3 commented Mar 9, 2021

Thanks for fixing our installer. I will check this tomorrow

@@ -299,7 +299,7 @@ case ${ANSWER:0:1} in
docker pull fkiecad/fact_extractor:latest
fi
if ! [[ -f "./external/extract.py" ]]; then
download_file "FACT-extract" "https://raw.githubusercontent.com/fkie-cad/fact_extractor/master/extract.py" "external/extract.py"
Copy link
Member

@m-1-k-3 m-1-k-3 Mar 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering why the download_file should not work in this situation. I will try another fresh installation to check on this

@@ -369,6 +369,8 @@ print_file_info "$BINUTIL_VERSION_NAME" "The GNU Binutils are a collection of bi
print_tool_info "texinfo" 1
print_tool_info "gcc" 1
print_tool_info "build-essential" 1
print_tool_info "gawk" 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should start commenting from which other tool/module this is needed. Could you please add this here.
We are going to start with the other tools

@@ -493,10 +524,10 @@ case ${ANSWER:0:1} in
y|Y )
sudo cve_searchsploit -u
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need this sudo here?
Should we run such an update also outside of the docker environment. Otherwise the first run will do it and it will take a while during the first emba run.

echo -e "\\n""$MAGENTA""$BOLD""For using CVE-search you have to install all the requirements and the needed database.""$NC"
echo -e "$MAGENTA""$BOLD""Installation instructions can be found on github.io: https://cve-search.github.io/cve-search/getting_started/installation.html#installation""$NC"
# echo -e "\\n""$MAGENTA""$BOLD""For using CVE-search you have to install all the requirements and the needed database.""$NC"
# echo -e "$MAGENTA""$BOLD""Installation instructions can be found on github.io: https://cve-search.github.io/cve-search/getting_started/installation.html#installation""$NC"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please remove these lines completely.

@m-1-k-3
Copy link
Member

m-1-k-3 commented Mar 11, 2021

Hi @Anemosx,

great work. Thank you. The installer is now able to bring up a fully working emba installation including cve-search with the needed database. A first run after installation gives the expected results:

image

Could you please take a quick look at the comments and afterwards we are ready to merge.

@m-1-k-3
Copy link
Member

m-1-k-3 commented Mar 12, 2021

@p4cx I will merge this now. Could you please include the comments in your cleanup? Thanks

@m-1-k-3 m-1-k-3 merged commit 21dd766 into e-m-b-a:master Mar 12, 2021
p4cx added a commit to p4cx/emba that referenced this pull request Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants