-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installer.sh #77
Conversation
Seems no need to ask again
In my opinion, this is as completely correct as it was. The step with the extra query is filling the database and that takes a good while. The installer in its normal form, without the |
Thank you @firmianay to check our installer. Probably @firmianay will find something more that we can check on Monday? ;) |
@firmianay I have checked it out now and I can see your point. The cve-database should be installed in default as it is a main element of a lot of areas of emba. But, as we got the feedback to be more granular in the possibilities a user has we have implemented the current behavior. As the user gets the help output if he does not pass arguments to the installer it is fine for me. |
That sounds fine. That's how we do it. |
Thanks for reply. Providing a "Force" option is of course a good choice, I just feel that some dependencies are not clear, some should be a mandatory component, not optional. Another example is 'git', used in the front process, but installed later again. |
Interesting. Probably we need to review it again. └─$ grep print_tool.*git installer.sh |
I will close this PR, the discussion for the review of the installer can now be found here: #85 Thanks to @firmianay again for your help. |
Seems no need to ask again