Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gpt path #789

Merged
merged 2 commits into from Sep 15, 2023
Merged

fix gpt path #789

merged 2 commits into from Sep 15, 2023

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Sep 15, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix
Thx @n0x08 for reporting this issue

  • What is the current behavior? (You can also link to an open issue here)

If EMBA identifies multiple root paths the cut_path functions is currently not able to handle this. This results in not finding the files for Q02

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

remove the log dir to use the path for searching.

@m-1-k-3 m-1-k-3 self-assigned this Sep 15, 2023
@m-1-k-3 m-1-k-3 added the prio Sponsored priority issue label Sep 15, 2023
@BenediktMKuehne BenediktMKuehne merged commit ba26122 into e-m-b-a:master Sep 15, 2023
12 checks passed
@m-1-k-3 m-1-k-3 deleted the fix-gpt-path branch October 2, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenediktMKuehne BenediktMKuehne BenediktMKuehne approved these changes

Assignees

@m-1-k-3 m-1-k-3

Labels
AI-assissted firmware analysis bug Something isn't working EMBA prio Sponsored priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m-1-k-3 @BenediktMKuehne