Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diff mode #867

Merged
merged 4 commits into from Nov 7, 2023
Merged

Improve diff mode #867

merged 4 commits into from Nov 7, 2023

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Nov 6, 2023 •
edited

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

No threading support
missing text base diff of function diff

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

EMBA now respects the -t parameter also in diff mode

Disassembly of diffed functions available via HTML report

image

Further detailed diff is now also available

image

@m-1-k-3 m-1-k-3 added enhancement New feature or request in progress Someone is working on this EMBA Firmware diffing - D modules labels Nov 6, 2023
@m-1-k-3 m-1-k-3 marked this pull request as ready for review November 7, 2023 07:15
This was referenced Nov 7, 2023
Merged
Merged
@m-1-k-3 m-1-k-3 removed the in progress Someone is working on this label Nov 7, 2023
@m-1-k-3 m-1-k-3 merged commit ac5672b into e-m-b-a:master Nov 7, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenediktMKuehne BenediktMKuehne BenediktMKuehne approved these changes

Assignees
No one assigned
Labels
EMBA enhancement New feature or request Firmware diffing - D modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m-1-k-3 @BenediktMKuehne