fwhunt check entire firmware first #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-1-k-3
requested changes
Nov 13, 2023
modules/S02_UEFI_FwHunt.sh
Outdated
| fi | ||
| done | ||
| fwhunter "${FIRMWARE_PATH_BAK}" | ||
| if [[ $(grep -c "FwHunt rule" "${LOG_PATH_MODULE}""/fwhunt_scan_"*) -eq 0 ]]; then |
There was a problem hiding this comment.
this grep gives you output like the following:
file1:0
file2:1
file3:7
You probably need to add them before checking them
grep -c ... | cut -d: -f2 | awk '{ SUM += $1} END { print SUM }' || true) -eq 0 ]] ...
m-1-k-3
reviewed
Nov 13, 2023
m-1-k-3
approved these changes
Nov 13, 2023
m-1-k-3
reviewed
Nov 13, 2023
| fwhunter "${EXTRACTED_FILE}" | ||
| fi | ||
| done | ||
| fwhunter "${FIRMWARE_PATH_BAK}" |
There was a problem hiding this comment.
one last suggestion: Could you please add a comment why we are doing this. Otherwise I think we can't remember about this trick in a year or so ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fwhunt first is run on the unextracted firmware, if it does not find anything, it continues checking each file in a for loop
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)? If possible add a screenshot.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: