Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for versions (emba, git and docker) #918

Merged
merged 16 commits into from Nov 30, 2023
Merged

Conversation

HoxhaEndri
Copy link
Member

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    It checks for the versions of emba, git and docker. It uses a new script to update the VERSION.txt file.

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

Copy link
Member

@m-1-k-3 m-1-k-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool PR with valuable details regarding updates. Could you please check my comments?

helpers/create_version.sh Outdated Show resolved Hide resolved
helpers/helpers_emba_dependency_check.sh Outdated Show resolved Hide resolved
helpers/helpers_emba_dependency_check.sh Outdated Show resolved Hide resolved
helpers/helpers_emba_dependency_check.sh Outdated Show resolved Hide resolved
helpers/helpers_emba_dependency_check.sh Outdated Show resolved Hide resolved
helpers/helpers_emba_dependency_check.sh Outdated Show resolved Hide resolved
helpers/helpers_emba_dependency_check.sh Outdated Show resolved Hide resolved
helpers/helpers_emba_dependency_check.sh Outdated Show resolved Hide resolved
@m-1-k-3 m-1-k-3 added enhancement New feature or request EMBA labels Nov 29, 2023
Copy link
Member

@m-1-k-3 m-1-k-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge the current master of EMBA to ensure everything will run smooth

helpers/helpers_emba_dependency_check.sh Outdated Show resolved Hide resolved
helpers/helpers_emba_dependency_check.sh Outdated Show resolved Hide resolved
@m-1-k-3
Copy link
Member

m-1-k-3 commented Nov 30, 2023

This looks really useful

image

@m-1-k-3 m-1-k-3 merged commit 1a06924 into e-m-b-a:master Nov 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EMBA enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants