Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove disable shellcheck from installer folder scripts #941

Merged
merged 4 commits into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions installer/IL15_emulated_checks_init.sh
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,10 @@ IL15_emulated_checks_init() {
sed -i 's/routersploit\.log/\/tmp\/routersploit\.log/' ./rsf.py
fi
# patch some code to write the history files to a subdirectory in /root
# shellcheck disable=SC2088
if grep -q '~/.history' ./routersploit/interpreter.py; then
if grep -q ~/'.history' ./routersploit/interpreter.py; then
sed -i 's/~\/\.history/~\/\.routersploit\/\.history/' ./routersploit/interpreter.py
fi
# shellcheck disable=SC2088
if grep -q '~/.rsf_history' ./routersploit/interpreter.py; then
if grep -q ~/'.rsf_history' ./routersploit/interpreter.py; then
HoxhaEndri marked this conversation as resolved.
Show resolved Hide resolved
sed -i 's/~\/\.rsf_history/~\/\.routersploit\/\.rsf_history/' ./routersploit/interpreter.py
fi

Expand Down
3 changes: 1 addition & 2 deletions installer/wickStrictModeFail.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ wickStrictModeFail() (
if [[ ${#BASH_ARGC[@]} -gt ${i} ]] && [[ ${#BASH_ARGV[@]} -ge $(( nextArg + BASH_ARGC[i] )) ]]; then
for (( argsLeft = BASH_ARGC[i]; argsLeft; --argsLeft )); do
# Note: this reverses the order on purpose
# shellcheck disable=SC2004
argsList[${argsLeft}]=${BASH_ARGV[nextArg]}
argsList[argsLeft]=${BASH_ARGV[nextArg]}
(( nextArg ++ ))
done

Expand Down