New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of binary name from binary version string #942

Merged

m-1-k-3 merged 1 commit into e-m-b-a:master from mj138:patch-2

Dec 5, 2023

Contributor

mj138 commented Dec 5, 2023

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Code currently pulls binary name from the first field of the binary version string, like so:

bin_name:version

But in some cases we have an identifier like the following:

vendor:bin_name:version

What is the new behavior (if this is a feature change)? If possible add a screenshot.
Updated code pulls binary name from second to last field of the binary version string, which should better handle cases in which there are 3+ fields, as described above.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Hopefully not!
Other information:


          Fix parsing of binary name from binary version string

b310790

m-1-k-3 added bug EMBA labels

m-1-k-3 approved these changes

View reviewed changes

Member

m-1-k-3 left a comment

thx for the fix

m-1-k-3 merged commit dc1977f into e-m-b-a:master

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment