Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force utf8 for htmls #964

Merged
merged 6 commits into from Dec 18, 2023
Merged

force utf8 for htmls #964

merged 6 commits into from Dec 18, 2023

Conversation

BenediktMKuehne
Copy link
Member

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    force all strings inside the htmls to be in utf8 format

  • What is the current behavior? (You can also link to an open issue here)
    unicode problems

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.
    html gets force converted into utf-8

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:
    embark#183

@BenediktMKuehne BenediktMKuehne added bug Something isn't working EMBArk reporting reporting topics (e.g., web reporter) EMBA labels Dec 14, 2023
@BenediktMKuehne BenediktMKuehne marked this pull request as ready for review December 14, 2023 14:06
@BenediktMKuehne BenediktMKuehne marked this pull request as draft December 15, 2023 08:07
@BenediktMKuehne BenediktMKuehne marked this pull request as ready for review December 18, 2023 13:26
@m-1-k-3 m-1-k-3 merged commit 9fb2dd8 into e-m-b-a:master Dec 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EMBA EMBArk reporting reporting topics (e.g., web reporter)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants