Performance updates #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p4cx
reviewed
Apr 21, 2021
helpers/helpers.sh
Outdated
| # | ||
| # Author(s): Michael Messner, Pascal Eckmann | ||
|
|
||
| # Description: Multiple usefull helpers |
p4cx
reviewed
Apr 21, 2021
| TEMP_PIDS=() | ||
| # check for really running PIDs and re-create the array | ||
| for PID in ${WAIT_PIDS[*]}; do | ||
| #print_output "[*] max pid protection: ${#WAIT_PIDS[@]}" |
There was a problem hiding this comment.
Please delete all the comments lines with printing statements.
There was a problem hiding this comment.
lets leave it here for further debugging in the next days
p4cx
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple speed improvements. Emba now takes all the cores:
Started last week with the runtime:
[!] Test ended on Sa 17. Apr 15:11:05 CEST 2021 and took about 01:24:07
Current runtime:
[!] Test ended on Mi 21. Apr 15:37:30 CEST 2021 and took about 00:29:10
There are multiple areas that we can improve in future. Currently a lot of modules are not finally optimised and are not running on multiple cores.
Additionally I have started a Strg-C catcher. So, that we are able to cleanup a bit if we kill emba. Currently it is always a mess.